Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add mainnet timestamp for shanghai #1829

Merged
merged 2 commits into from
Mar 18, 2023
Merged

feat: add mainnet timestamp for shanghai #1829

merged 2 commits into from
Mar 18, 2023

Conversation

onbjerg
Copy link
Member

@onbjerg onbjerg commented Mar 18, 2023

@onbjerg onbjerg added C-enhancement New feature or request A-consensus Related to the consensus engine labels Mar 18, 2023
@onbjerg onbjerg requested a review from gakonst as a code owner March 18, 2023 07:10
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2023 •
edited
Loading

Codecov Report

Merging #1829 (41053eb) into main (d774d91) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1829      +/-   ##
==========================================
- Coverage   73.53%   73.49%   -0.04%     
==========================================
  Files         410      410              
  Lines       50510    50398     -112     
==========================================
- Hits        37144    37042     -102     
+ Misses      13366    13356      -10
Flag Coverage Δ
integration-tests 19.79% <8.33%> (+0.10%) ⬆️
unit-tests 67.81% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/primitives/src/chain/spec.rs 97.77% <100.00%> (-0.18%) ⬇️

... and 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

rkrasiuk
rkrasiuk approved these changes Mar 18, 2023
View reviewed changes
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo test removal

crates/primitives/src/chain/spec.rs Outdated Show resolved Hide resolved
@onbjerg onbjerg merged commit 85076fb into main Mar 18, 2023
@onbjerg onbjerg deleted the onbjerg/shanghai-ts branch March 18, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@mattsse mattsse mattsse approved these changes

@gakonst gakonst Awaiting requested review from gakonst

Assignees
No one assigned
Labels
A-consensus Related to the consensus engine C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@onbjerg @codecov-commenter @mattsse @rkrasiuk